Change extension unload notification to indicate updates....

chrome/browser/automation/automation_extension_tracker.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_extension_tracker.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/notification_service.h"
 
 AutomationExtensionTracker::AutomationExtensionTracker(
     IPC::Message::Sender* automation)
     : AutomationResourceTracker<const Extension*>(automation) {
   registrar_.Add(this, NotificationType::EXTENSION_UNLOADED,
                  NotificationService::AllSources());
-  registrar_.Add(this, NotificationType::EXTENSION_UNLOADED_DISABLED,
-                 NotificationService::AllSources());
 }
 
 AutomationExtensionTracker::~AutomationExtensionTracker() {
 }
 
 void AutomationExtensionTracker::AddObserver(const Extension* resource) {}
 
 void AutomationExtensionTracker::RemoveObserver(const Extension* resource) {}
 
 void AutomationExtensionTracker::Observe(NotificationType type,
                                          const NotificationSource& source,
                                          const NotificationDetails& details) {
-  if (type != NotificationType::EXTENSION_UNLOADED &&
-      type != NotificationType::EXTENSION_UNLOADED_DISABLED)
+  if (type != NotificationType::EXTENSION_UNLOADED)

[Erik does not do reviews, 2010/12/23 17:05:17]

should this be NOTREACHED()?

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

Done.

     return;
 
-  const Extension* extension = Details<const Extension>(details).ptr();
+  const Extension* extension =
+      Details<UnloadedExtensionInfo>(details)->extension;

[Erik does not do reviews, 2010/12/23 17:05:17]

extension can be NULL right?  so it looks like a crash can happen here.

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

It turns out it can't. See my response to comments on extension.h.

   Profile* profile = Source<Profile>(source).ptr();
   if (profile) {
     ExtensionService* service = profile->GetExtensionService();
     if (service) {
       // Remove this extension only if it is uninstalled, not just disabled.
       // If it is being uninstalled, the extension will not be in the regular
       // or disabled list.
       if (!service->GetExtensionById(extension->id(), true))

[Erik does not do reviews, 2010/12/23 17:05:17]

extension can be NULL right?  so it looks like a crash can happen here.  this
should just change to look at the reason.

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

It turns out it can't.

         CloseResource(extension);
     }
   }
 }