Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Side by Side Diff: base/version.h

Issue 5848005: base/version: remove wstring version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: retry Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_VERSION_H_ 5 #ifndef BASE_VERSION_H_
6 #define BASE_VERSION_H_ 6 #define BASE_VERSION_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/gtest_prod_util.h" 13 #include "base/gtest_prod_util.h"
14 14
15 // Version represents a dotted version number, like "1.2.3.4", supporting
16 // parsing and comparison.
17 // Each component is limited to a uint16.
15 class Version { 18 class Version {
16 public: 19 public:
17 // The version string must be made up of 1 or more uint16's separated 20 // The version string must be made up of 1 or more uint16's separated
18 // by '.'. Returns NULL if string is not in this format. 21 // by '.'. Returns NULL if string is not in this format.
19 // Caller is responsible for freeing the Version object once done. 22 // Caller is responsible for freeing the Version object once done.
20 static Version* GetVersionFromString(const std::wstring& version_str);
21 static Version* GetVersionFromString(const std::string& version_str); 23 static Version* GetVersionFromString(const std::string& version_str);
22 24
23 // Exposed only so that a Version can be stored in STL containers; 25 // Exposed only so that a Version can be stored in STL containers;
24 // any call to the methods below on a default-constructed Version 26 // any call to the methods below on a default-constructed Version
25 // will DCHECK. 27 // will DCHECK.
26 Version(); 28 Version();
27 29
28 ~Version(); 30 ~Version();
29 31
30 bool Equals(const Version& other) const; 32 bool Equals(const Version& other) const;
(...skipping 11 matching lines...) Expand all
42 44
43 bool is_valid_; 45 bool is_valid_;
44 std::vector<uint16> components_; 46 std::vector<uint16> components_;
45 47
46 FRIEND_TEST_ALL_PREFIXES(VersionTest, DefaultConstructor); 48 FRIEND_TEST_ALL_PREFIXES(VersionTest, DefaultConstructor);
47 FRIEND_TEST_ALL_PREFIXES(VersionTest, GetVersionFromString); 49 FRIEND_TEST_ALL_PREFIXES(VersionTest, GetVersionFromString);
48 FRIEND_TEST_ALL_PREFIXES(VersionTest, Compare); 50 FRIEND_TEST_ALL_PREFIXES(VersionTest, Compare);
49 }; 51 };
50 52
51 #endif // BASE_VERSION_H_ 53 #endif // BASE_VERSION_H_
OLDNEW
« no previous file with comments | « no previous file | base/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698