chrome/installer/util/helper_unittest.cc - Issue 5848005: base/version: remove wstring version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/helper_unittest.cc

Issue 5848005: base/version: remove wstring version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: retry Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/helper_unittest.cc

diff --git a/chrome/installer/util/helper_unittest.cc b/chrome/installer/util/helper_unittest.cc

index 7c1e955900ed5b489f9c107a89a1f77f67c32f14..5f02a7e8bbc440a2f84c967b77974fc6d7c9aab0 100644

--- a/chrome/installer/util/helper_unittest.cc

+++ b/chrome/installer/util/helper_unittest.cc

@@ -109,7 +109,7 @@ TEST_F(SetupHelperTest, Delete) {

CreateTextFile(chrome_dll_4.value(), text_content_1);

ASSERT_TRUE(file_util::PathExists(chrome_dll_4));

- scoped_ptr<Version> latest_version(Version::GetVersionFromString(L"1.0.4.0"));

+ scoped_ptr<Version> latest_version(Version::GetVersionFromString("1.0.4.0"));

ChromePackageProperties properties;

scoped_refptr<Package> package(new Package(true, chrome_dir, &properties));

package->RemoveOldVersionDirectories(*latest_version.get());

@@ -184,7 +184,7 @@ TEST_F(SetupHelperTest, DeleteInUsed) {

CreateTextFile(chrome_dll_4.value(), text_content_1);

ASSERT_TRUE(file_util::PathExists(chrome_dll_4));

- scoped_ptr<Version> latest_version(Version::GetVersionFromString(L"1.0.4.0"));

+ scoped_ptr<Version> latest_version(Version::GetVersionFromString("1.0.4.0"));

ChromePackageProperties properties;

scoped_refptr<Package> install_path(new Package(true, chrome_dir,

&properties));

« no previous file with comments | « chrome/installer/setup/setup_util.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »