Issue 5833001: Fix for occasional crash when submitting feedback on a page that is not yet loaded it's title.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5833001: Fix for occasional crash when submitting feedback on a page that is not yet loaded it's title. (Closed)

Created:
10 years ago by rkc

Modified:
9 years, 7 months ago

Reviewers:
oshima, zel, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix for occasional crash when submitting feedback on a page that is not yet loaded it's title. BUG=66767 TEST=Couldn't repro the problem anymore, but, couldn't repro it more than once even earlier. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69200

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed to use GetURL #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/dom_ui/bug_report_ui.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/5833001/diff/1/chrome/browser/dom_ui/bug_report_ui.cc File chrome/browser/dom_ui/bug_report_ui.cc (right): http://codereview.chromium.org/5833001/diff/1/chrome/browser/dom_ui/bug_report_ui.cc#newcode573 chrome/browser/dom_ui/bug_report_ui.cc:573: if (target_tab->controller().GetActiveEntry()) { Why doesn't this use target_tab->GetURL()? That ...

10 years ago (2010-12-14 23:06:18 UTC) #2

rkc

Review comments incorporated. http://codereview.chromium.org/5833001/diff/1/chrome/browser/dom_ui/bug_report_ui.cc File chrome/browser/dom_ui/bug_report_ui.cc (right): http://codereview.chromium.org/5833001/diff/1/chrome/browser/dom_ui/bug_report_ui.cc#newcode573 chrome/browser/dom_ui/bug_report_ui.cc:573: if (target_tab->controller().GetActiveEntry()) { On 2010/12/14 23:06:18, ...

10 years ago (2010-12-14 23:20:44 UTC) #3

LGTM

Expand Messages | Collapse Messages