Fix for occasional crash when submitting feedback on a page that is not yet loaded it's title.

chrome/browser/dom_ui/bug_report_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/bug_report_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 552 matching lines @@
   if (((index == 0) && (params != "0")) || !browser ||
       index >= browser->tab_count()) {
     return base::StringPiece(
         ResourceBundle::GetSharedInstance().GetRawDataResource(
             IDR_BUGREPORT_HTML_INVALID));
   }
 
   TabContents* target_tab = browser->GetTabContentsAt(index);
   if (target_tab) {
     target_tab_title_ = target_tab->GetTitle();
-    target_tab_url_ = target_tab->controller().GetActiveEntry()->url().spec();
+    if (target_tab->controller().GetActiveEntry()) {

[sky, 2010/12/14 23:06:18]

Why doesn't this use target_tab->GetURL()? That deals with the null check.

[rkc, 2010/12/14 23:20:48]

This is code pulled from the legacy report a bug dialog, not sure why it was
done this way. Anyway, GetURL works fine, so changed it.

Done.

+      target_tab_url_ =
+          target_tab->controller().GetActiveEntry()->url().spec();
+    }
   }
 
   // Setup the screenshot source after we've verified input is legit.
   SetupScreenshotsSource();
 
   return base::StringPiece(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_BUGREPORT_HTML));
 }
 
@@ skipping 216 matching lines @@
   BugReportUIHTMLSource* html_source =
       new BugReportUIHTMLSource(handler->Init());
   // Set up the chrome://bugreport/ source.
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableMethod(
           ChromeURLDataManager::GetInstance(),
           &ChromeURLDataManager::AddDataSource,
           make_scoped_refptr(html_source)));
 }