chrome/browser/dom_ui/bug_report_ui.cc - Issue 5833001: Fix for occasional crash when submitting feedback on a page that is not yet loaded it's title.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/bug_report_ui.cc

Issue 5833001: Fix for occasional crash when submitting feedback on a page that is not yet loaded it's title. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed to use GetURL Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/dom_ui/bug_report_ui.cc

diff --git a/chrome/browser/dom_ui/bug_report_ui.cc b/chrome/browser/dom_ui/bug_report_ui.cc

index 4d8bc83b7e9896eb424a025eddae264f3cea5832..dd256365adcdf514a4692a6d0dfa41858a3c6d46 100644

--- a/chrome/browser/dom_ui/bug_report_ui.cc

+++ b/chrome/browser/dom_ui/bug_report_ui.cc

@@ -570,7 +570,7 @@ base::StringPiece BugReportHandler::Init() {

TabContents* target_tab = browser->GetTabContentsAt(index);

if (target_tab) {

target_tab_title_ = target_tab->GetTitle();

- target_tab_url_ = target_tab->controller().GetActiveEntry()->url().spec();

+ target_tab_url_ = target_tab->GetURL().spec();

}

// Setup the screenshot source after we've verified input is legit.

« no previous file with comments | « no previous file | no next file » | no next file with comments »