chrome/browser/safe_browsing/protocol_manager.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed logging to vlog Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/protocol_manager.cc

diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc

index 8e29489e072dd1460f47cd83b8929919fe5ba6d6..6b59b9613a89c7503a176e5240546c813ccb9f1f 100644

--- a/chrome/browser/safe_browsing/protocol_manager.cc

+++ b/chrome/browser/safe_browsing/protocol_manager.cc

@@ -119,10 +119,7 @@ SafeBrowsingProtocolManager::SafeBrowsingProtocolManager(

next_update_sec_ = base::RandInt(60, kSbTimerStartIntervalSec);

chrome::VersionInfo version_info;

- if (!version_info.is_valid() || version_info.Version().empty())

- version_ = "0.1";

- else

- version_ = version_info.Version();

+ version_ = version_info.Version();

}

SafeBrowsingProtocolManager::~SafeBrowsingProtocolManager() {