Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7446)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/sync/glue/sync_backend_host.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed logging to vlog Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/file_version_info_mac.mm ('K') | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/upgrade_detector.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/sync_backend_host.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host.cc b/chrome/browser/sync/glue/sync_backend_host.cc
index fb63ce5e44b6c34c2b046e2204ece1a1d0e1224d..7dc68f2123fad30f2ef9372956367856500522df 100644
--- a/chrome/browser/sync/glue/sync_backend_host.cc
+++ b/chrome/browser/sync/glue/sync_backend_host.cc
@@ -483,11 +483,6 @@ std::string MakeUserAgentForSyncapi() {
user_agent += "MAC ";
#endif
chrome::VersionInfo version_info;
- if (!version_info.is_valid()) {
- DLOG(ERROR) << "Unable to create chrome::VersionInfo object";
- return user_agent;
- }
-
user_agent += version_info.Version();
user_agent += " (" + version_info.LastChange() + ")";
if (!version_info.IsOfficialBuild())
« base/file_version_info_mac.mm ('K') | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/upgrade_detector.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698