Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed logging to vlog Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/file_version_info_mac.mm ('K') | « chrome/browser/memory_details_mac.cc ('k') | chrome/browser/safe_browsing/protocol_manager.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_log.cc
diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc
index d0a1f0168f392d8e33c734f8a0d459f121d1608a..14f6ba90a689db1df3162695eaf9252732039c42 100644
--- a/chrome/browser/metrics/metrics_log.cc
+++ b/chrome/browser/metrics/metrics_log.cc
@@ -71,11 +71,6 @@ std::string MetricsLog::GetInstallDate() const {
// static
std::string MetricsLog::GetVersionString() {
chrome::VersionInfo version_info;
- if (!version_info.is_valid()) {
- NOTREACHED() << "Unable to retrieve version info.";
- return std::string();
- }
-
std::string version = version_info.Version();
if (!version_extension_.empty())
version += version_extension_;
« base/file_version_info_mac.mm ('K') | « chrome/browser/memory_details_mac.cc ('k') | chrome/browser/safe_browsing/protocol_manager.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698