Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5799001: DOMUI: Temporarily strip trailing colons from section titles until the strings (Closed)

Created:
10 years ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
csilv
CC:
chromium-reviews
Visibility:
Public.

Description

DOMUI: Temporarily strip trailing colons from section titles until the strings can be changed. BUG=62875 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68923

Patch Set 1 #

Total comments: 2

Patch Set 2 : Compile fix. #

Patch Set 3 : Win build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 1 2 3 chunks +18 lines, -6 lines 0 comments Download
M chrome/browser/dom_ui/options/browser_options_handler.cc View 1 2 4 chunks +11 lines, -5 lines 0 comments Download
A chrome/browser/dom_ui/options/dom_options_util.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/options/dom_options_util.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/personal_options_handler.cc View 1 2 5 chunks +13 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
10 years ago (2010-12-10 23:57:14 UTC) #1
csilv
http://codereview.chromium.org/5799001/diff/1/chrome/browser/dom_ui/options/personal_options_handler.cc File chrome/browser/dom_ui/options/personal_options_handler.cc (right): http://codereview.chromium.org/5799001/diff/1/chrome/browser/dom_ui/options/personal_options_handler.cc#newcode105 chrome/browser/dom_ui/options/personal_options_handler.cc:105: l10n_util::GetStringUTF16(IDS_THEMES_GROUP_NAME)); add missing ')' (courtesy trybot)
10 years ago (2010-12-11 00:28:35 UTC) #2
James Hawkins
http://codereview.chromium.org/5799001/diff/1/chrome/browser/dom_ui/options/personal_options_handler.cc File chrome/browser/dom_ui/options/personal_options_handler.cc (right): http://codereview.chromium.org/5799001/diff/1/chrome/browser/dom_ui/options/personal_options_handler.cc#newcode105 chrome/browser/dom_ui/options/personal_options_handler.cc:105: l10n_util::GetStringUTF16(IDS_THEMES_GROUP_NAME)); On 2010/12/11 00:28:35, csilv wrote: > add missing ...
10 years ago (2010-12-11 00:32:19 UTC) #3
csilv
10 years ago (2010-12-11 01:55:17 UTC) #4 
LGTM after green trybots

Powered by Google App Engine
This is Rietveld 408576698