Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3020)

Unified Diff: chrome/browser/dom_ui/options/browser_options_handler.cc

Issue 5799001: DOMUI: Temporarily strip trailing colons from section titles until the strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fix. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/options/browser_options_handler.cc
diff --git a/chrome/browser/dom_ui/options/browser_options_handler.cc b/chrome/browser/dom_ui/options/browser_options_handler.cc
index 03773cb693312feb8aac80faa95e476c560d6e31..863b461af44e3f2b58303962d049c266d39d4ccd 100644
--- a/chrome/browser/dom_ui/options/browser_options_handler.cc
+++ b/chrome/browser/dom_ui/options/browser_options_handler.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/browser_thread.h"
#include "chrome/browser/custom_home_pages_table_model.h"
#include "chrome/browser/dom_ui/dom_ui_favicon_source.h"
+#include "chrome/browser/dom_ui/options/dom_options_util.h"
#include "chrome/browser/dom_ui/options/options_managed_banner_handler.h"
#include "chrome/browser/instant/instant_confirm_dialog.h"
#include "chrome/browser/metrics/user_metrics.h"
@@ -45,7 +46,8 @@ void BrowserOptionsHandler::GetLocalizedValues(
DictionaryValue* localized_strings) {
DCHECK(localized_strings);
localized_strings->SetString("startupGroupName",
- l10n_util::GetStringUTF16(IDS_OPTIONS_STARTUP_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_STARTUP_GROUP_NAME)));
localized_strings->SetString("startupShowDefaultAndNewTab",
l10n_util::GetStringUTF16(IDS_OPTIONS_STARTUP_SHOW_DEFAULT_AND_NEWTAB));
localized_strings->SetString("startupShowLastSession",
@@ -57,17 +59,20 @@ void BrowserOptionsHandler::GetLocalizedValues(
localized_strings->SetString("startupUseCurrent",
l10n_util::GetStringUTF16(IDS_OPTIONS_STARTUP_USE_CURRENT));
localized_strings->SetString("homepageGroupName",
- l10n_util::GetStringUTF16(IDS_OPTIONS_HOMEPAGE_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_HOMEPAGE_GROUP_NAME)));
localized_strings->SetString("homepageUseNewTab",
l10n_util::GetStringUTF16(IDS_OPTIONS_HOMEPAGE_USE_NEWTAB));
localized_strings->SetString("homepageUseURL",
l10n_util::GetStringUTF16(IDS_OPTIONS_HOMEPAGE_USE_URL));
localized_strings->SetString("toolbarGroupName",
- l10n_util::GetStringUTF16(IDS_OPTIONS_TOOLBAR_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_TOOLBAR_GROUP_NAME)));
localized_strings->SetString("toolbarShowHomeButton",
l10n_util::GetStringUTF16(IDS_OPTIONS_TOOLBAR_SHOW_HOME_BUTTON));
localized_strings->SetString("defaultSearchGroupName",
- l10n_util::GetStringUTF16(IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME)));
localized_strings->SetString("defaultSearchManageEngines",
l10n_util::GetStringUTF16(IDS_OPTIONS_DEFAULTSEARCH_MANAGE_ENGINES));
localized_strings->SetString("instantName",
@@ -81,7 +86,8 @@ void BrowserOptionsHandler::GetLocalizedValues(
localized_strings->SetString("instantConfirmMessage",
l10n_util::GetStringUTF16(IDS_INSTANT_OPT_IN_MESSAGE));
localized_strings->SetString("defaultBrowserGroupName",
- l10n_util::GetStringUTF16(IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME)));
localized_strings->SetString("defaultBrowserUnknown",
l10n_util::GetStringFUTF16(IDS_OPTIONS_DEFAULTBROWSER_UNKNOWN,
l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)));
« no previous file with comments | « chrome/browser/dom_ui/options/advanced_options_handler.cc ('k') | chrome/browser/dom_ui/options/dom_options_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698