Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: chrome/browser/dom_ui/options/personal_options_handler.cc

Issue 5799001: DOMUI: Temporarily strip trailing colons from section titles until the strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fix. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/options/dom_options_util.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/options/personal_options_handler.cc
diff --git a/chrome/browser/dom_ui/options/personal_options_handler.cc b/chrome/browser/dom_ui/options/personal_options_handler.cc
index 8abb491b839d8ff72079e3b962f40ac5231bcb6c..86ff254fde96dc286d312ee2b53549b96eea2857 100644
--- a/chrome/browser/dom_ui/options/personal_options_handler.cc
+++ b/chrome/browser/dom_ui/options/personal_options_handler.cc
@@ -15,6 +15,7 @@
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/dom_ui/options/dom_options_util.h"
#include "chrome/browser/dom_ui/options/options_managed_banner_handler.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -54,12 +55,14 @@ void PersonalOptionsHandler::GetLocalizedValues(
DCHECK(localized_strings);
localized_strings->SetString("syncSection",
- l10n_util::GetStringUTF16(IDS_SYNC_OPTIONS_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_SYNC_OPTIONS_GROUP_NAME)));
localized_strings->SetString("privacyDashboardLink",
l10n_util::GetStringUTF16(IDS_SYNC_PRIVACY_DASHBOARD_LINK_LABEL));
localized_strings->SetString("passwords",
- l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_GROUP_NAME)));
localized_strings->SetString("passwordsAskToSave",
l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_ASKTOSAVE));
localized_strings->SetString("passwordsNeverSave",
@@ -68,12 +71,14 @@ void PersonalOptionsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_MANAGE_PASSWORDS));
localized_strings->SetString("autofill",
- l10n_util::GetStringUTF16(IDS_AUTOFILL_SETTING_WINDOWS_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_SETTING_WINDOWS_GROUP_NAME)));
localized_strings->SetString("manageAutofillSettings",
l10n_util::GetStringUTF16(IDS_OPTIONS_MANAGE_AUTOFILL_SETTINGS));
localized_strings->SetString("browsingData",
- l10n_util::GetStringUTF16(IDS_OPTIONS_BROWSING_DATA_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_BROWSING_DATA_GROUP_NAME)));
localized_strings->SetString("importData",
l10n_util::GetStringUTF16(IDS_OPTIONS_IMPORT_DATA_BUTTON));
@@ -84,7 +89,8 @@ void PersonalOptionsHandler::GetLocalizedValues(
#if defined(TOOLKIT_GTK)
localized_strings->SetString("appearance",
- l10n_util::GetStringUTF16(IDS_APPEARANCE_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_APPEARANCE_GROUP_NAME)));
localized_strings->SetString("themesGTKButton",
l10n_util::GetStringUTF16(IDS_THEMES_GTK_BUTTON));
localized_strings->SetString("themesSetClassic",
@@ -95,7 +101,8 @@ void PersonalOptionsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(IDS_HIDE_WINDOW_DECORATIONS_RADIO));
#else
localized_strings->SetString("themes",
- l10n_util::GetStringUTF16(IDS_THEMES_GROUP_NAME));
+ dom_options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_THEMES_GROUP_NAME)));
localized_strings->SetString("themesReset",
l10n_util::GetStringUTF16(IDS_THEMES_RESET_BUTTON));
#endif
« no previous file with comments | « chrome/browser/dom_ui/options/dom_options_util.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698