Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5794003: Deinline even more destructors. (Closed)

Created:
10 years ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc, stuartmorgan+watch_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, dhollowa, cbentzel+watch_chromium.org, fbarchard, idana, Erik does not do reviews, jam, acolwell GONE FROM CHROMIUM, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, Raghu Simha, ncarter (slow), pam+watch_chromium.org, awong, James Hawkins, scherkus (not reviewing), sjl, Sergey Ulanov, Alpha Left Google, Aaron Boodman, dmac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Deinline even more destructors. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1009 lines, -428 lines) Patch
M chrome/browser/autofill/address_field.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/address_field.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/home_phone_number.h View 1 chunk +6 lines, -20 lines 0 comments Download
A chrome/browser/autofill/home_phone_number.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_test.h View 3 chunks +10 lines, -33 lines 0 comments Download
A chrome/browser/diagnostics/diagnostics_test.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_screenshot_source.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_screenshot_source.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/fileicon_source.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/dom_ui/fileicon_source.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/history2_ui.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/history2_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/options/options_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/gtk/download_shelf_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/download_shelf_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/html_dialog_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/html_dialog_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/translate/translate_infobar_base_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/translate/translate_infobar_base_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/modal_html_dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/modal_html_dialog_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/net/url_request_slow_download_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_request_slow_download_job.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/asynchronous_policy_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/asynchronous_policy_loader.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/file_based_policy_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/file_based_policy_loader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_value_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_map.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prefs/value_map_pref_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/value_map_pref_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/printing/printer_query.h View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/remoting/remoting_resources_source.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/remoting/remoting_resources_source.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_sqlite.h View 2 chunks +17 lines, -56 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc View 3 chunks +77 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_cert_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_cert_error_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/app_data_type_controller.h View 1 chunk +9 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/app_data_type_controller.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +5 lines, -17 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.h View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/change_processor.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 1 chunk +9 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.h View 1 chunk +5 lines, -16 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.h View 2 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/json_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/translate_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/bitstream_converter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/bitstream_converter.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/omx_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/omx_video_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine.h View 1 chunk +2 lines, -4 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M media/video/omx_video_decode_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M media/video/omx_video_decode_engine.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_linux.h View 1 chunk +3 lines, -12 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/socket/socks5_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/socks_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_ftp_job.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_class.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_plugin_object.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_group.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_group.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_stream_url.h View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_stream_url.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_2d_device_delegate.h View 1 chunk +7 lines, -21 lines 0 comments Download
A webkit/glue/plugins/webplugin_2d_device_delegate.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_3d_device_delegate.h View 2 chunks +15 lines, -45 lines 0 comments Download
A webkit/glue/plugins/webplugin_3d_device_delegate.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_audio_device_delegate.h View 1 chunk +7 lines, -21 lines 0 comments Download
A webkit/glue/plugins/webplugin_audio_device_delegate.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
A webkit/glue/plugins/webplugin_delegate.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
More of the same.
10 years ago (2010-12-14 00:32:02 UTC) #1
James Hawkins
10 years ago (2010-12-14 00:35:40 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698