Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: chrome/browser/sync/glue/autofill_profile_model_associator.h

Issue 5794003: Deinline even more destructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_profile_model_associator.h
diff --git a/chrome/browser/sync/glue/autofill_profile_model_associator.h b/chrome/browser/sync/glue/autofill_profile_model_associator.h
index 048b5a45855c8abca4987fd44953d4ab9a437340..ad8af5c304a832e9022e95e5aebbad515f7efa48 100644
--- a/chrome/browser/sync/glue/autofill_profile_model_associator.h
+++ b/chrome/browser/sync/glue/autofill_profile_model_associator.h
@@ -70,15 +70,10 @@ class AutofillProfileModelAssociator
// See ModelAssociator interface.
virtual void AbortAssociation();
- virtual const std::string* GetChromeNodeFromSyncId(
- int64 sync_id) {
- return NULL;
- }
+ virtual const std::string* GetChromeNodeFromSyncId(int64 sync_id);
virtual bool InitSyncNodeFromChromeId(const std::string& node_id,
- sync_api::BaseNode* sync_node) {
- return false;
- }
+ sync_api::BaseNode* sync_node);
// Returns the sync id for the given autofill name, or sync_api::kInvalidId
// if the autofill name is not associated to any sync id.
@@ -94,15 +89,13 @@ class AutofillProfileModelAssociator
// given permanent tag was found and update
// |sync_id| with that node's id. No current use. To Implement
// only for completeness.
- virtual bool GetSyncIdForTaggedNode(const std::string& tag, int64* sync_id) {
- return false;
- }
+ virtual bool GetSyncIdForTaggedNode(const std::string& tag, int64* sync_id);
// Returns sync service instance.
ProfileSyncService* sync_service() { return sync_service_; }
protected:
- AutofillProfileModelAssociator() {}
+ AutofillProfileModelAssociator();
bool TraverseAndAssociateChromeAutoFillProfiles(
sync_api::WriteTransaction* write_trans,
const sync_api::ReadNode& autofill_root,

Powered by Google App Engine
This is Rietveld 408576698