Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 5755003: Fix pyauto flakiness by waiting for notification that the renderer process' (Closed)

Created:
10 years ago by kkania
Modified:
9 years, 7 months ago
Reviewers:
AmolKher, Nirnimesh
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, anantha, dyu1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix pyauto flakiness by waiting for notification that the renderer process' termination has been noticed by the browser before reloading the associated tab. BUG=64708 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69154

Patch Set 1 : ... #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -10 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +19 lines, -0 lines 1 comment Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/functional/browser.py View 2 chunks +3 lines, -5 lines 1 comment Download
M chrome/test/functional/databases.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/functional/stress.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto.py View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
10 years ago (2010-12-10 18:12:35 UTC) #1
kkania
A short comment on why this is necessary: I noticed in the database test, via ...
10 years ago (2010-12-10 18:16:50 UTC) #2
AmolKher
LGTM with comments. http://codereview.chromium.org/5755003/diff/5001/chrome/browser/automation/automation_provider_observers.h File chrome/browser/automation/automation_provider_observers.h (right): http://codereview.chromium.org/5755003/diff/5001/chrome/browser/automation/automation_provider_observers.h#newcode996 chrome/browser/automation/automation_provider_observers.h:996: // Allos the automation provider to ...
10 years ago (2010-12-10 18:56:43 UTC) #3
Nirnimesh
10 years ago (2010-12-10 20:45:29 UTC) #4
LGTM.
Thanks for investigating.

Powered by Google App Engine
This is Rietveld 408576698