Fix pyauto flakiness by waiting for notification that the renderer process'

chrome/test/functional/browser.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import types
 
 import pyauto_functional  # Must be imported before pyauto
@@ skipping 123 matching lines @@
     # Verify there's only 1 flash process
     self.assertEqual(1, len(self._GetFlashProcessesInfo()))
 
   def testFlashLoadsAfterKill(self):
     """Verify that Flash process reloads after crashing (or being killed)."""
     flash_url = self.GetFileURLForPath(os.path.join(self.DataDir(),
                                                     'plugin', 'flash.swf'))
     self.NavigateToURL(flash_url)
     flash_process_id1 = self._GetFlashProcessesInfo()[0]['pid']
     self.Kill(flash_process_id1)
-    self.GetBrowserWindow(0).GetTab(0).Reload()  # Reload
+    self.ReloadActiveTab()
     flash_processes = self._GetFlashProcessesInfo()
     self.assertEqual(1, len(flash_processes))
     self.assertNotEqual(flash_process_id1, flash_processes[0]['pid'])
 
   def testMaxProcess(self):
     """Verify that opening 100 tabs doesn't create 100 child processes"""
     total_tabs = 100
     test_url = self.GetFileURLForDataPath('english_page.html')
     # Opening tabs
     for tab_index in range(total_tabs - 1):
       self.AppendTab(pyauto.GURL(test_url))
       tabs = self.GetBrowserInfo()['windows'][0]['tabs']
       # For the first time we have 2 tabs opened, so sending the tab_index as +2
       unique_renderers = self._GetUniqProcesses(len(tabs), tabs)
       # We verify that opening a new tab should not create a new process after
       # Chrome reaches to a maximum process limit.
       if len(tabs) > unique_renderers:
         return
     # In case if we create 100 processes for 100 tabs, then we are failing.
     self.fail(msg='Got 100 renderer processes')
 
   def testKillAndRelodRenderer(self):

[AmolKher, 2010/12/10 18:56:44]

:s/Relod/Reload

     """Verify that reloading of renderer is possible,
        after renderer is killed"""
     test_url = self.GetFileURLForDataPath('english_page.html')
     self.NavigateToURL(test_url)
     pid1 = self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid']
-    self.Kill(pid1)
-    tab = self.GetBrowserWindow(0).GetTab(0)
-    tab.Reload()
+    self.KillRendererProcess(pid1)
+    self.ReloadActiveTab()
     pid2 = self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid']
     self.assertNotEqual(pid1, pid2)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()
-