Chromium Code Reviews

Unified Diff: chrome/test/functional/browser.py

Issue 5755003: Fix pyauto flakiness by waiting for notification that the renderer process' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/test/functional/browser.py
diff --git a/chrome/test/functional/browser.py b/chrome/test/functional/browser.py
index 4228b9ca1d7b943e4148d7ccfdf94a5b298226dd..6320204394b51792ed9efd4ac87948fe8accc429 100644
--- a/chrome/test/functional/browser.py
+++ b/chrome/test/functional/browser.py
@@ -141,7 +141,7 @@ class BrowserTest(pyauto.PyUITest):
self.NavigateToURL(flash_url)
flash_process_id1 = self._GetFlashProcessesInfo()[0]['pid']
self.Kill(flash_process_id1)
- self.GetBrowserWindow(0).GetTab(0).Reload() # Reload
+ self.ReloadActiveTab()
flash_processes = self._GetFlashProcessesInfo()
self.assertEqual(1, len(flash_processes))
self.assertNotEqual(flash_process_id1, flash_processes[0]['pid'])
@@ -169,13 +169,11 @@ class BrowserTest(pyauto.PyUITest):
test_url = self.GetFileURLForDataPath('english_page.html')
self.NavigateToURL(test_url)
pid1 = self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid']
- self.Kill(pid1)
- tab = self.GetBrowserWindow(0).GetTab(0)
- tab.Reload()
+ self.KillRendererProcess(pid1)
+ self.ReloadActiveTab()
pid2 = self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid']
self.assertNotEqual(pid1, pid2)
if __name__ == '__main__':
pyauto_functional.Main()
-

Powered by Google App Engine