Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 5753001: add definition for GLchar to match khronos verion and Chrome's version (Closed)

Created:
10 years ago by jiesun
Modified:
9 years, 7 months ago
Reviewers:
Kenneth Waters, piman
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

add definition for GLchar to match khronos verion http://www.khronos.org/registry/gles/api/2.0/gl2.h and Chrome's version http://src.chromium.org/viewvc/chrome/trunk/src/gpu/GLES2/gl2.h?revision=52541&view=markup I am not sure about which ebuild should bump(probably x11-drivers/opengles-headers) and whether I could bump it in the same CL. Change-Id: Id60cef14201e389f8434f3c783de0645281d014d BUG=chromeos:1813 TEST=None. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bc3c148

Patch Set 1 #

Patch Set 2 : pull all new headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -60 lines) Patch
M include/EGL/eglext.h View 1 5 chunks +132 lines, -8 lines 0 comments Download
M include/EGL/eglplatform.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M include/GLES2/gl2.h View 1 10 chunks +22 lines, -21 lines 0 comments Download
M include/GLES2/gl2ext.h View 1 23 chunks +319 lines, -28 lines 0 comments Download
M include/GLES2/gl2platform.h View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jiesun
please take a look.
10 years ago (2010-12-09 22:06:16 UTC) #1
piman
Would it make sense to pull the latest headers from khronos ? I don't know ...
10 years ago (2010-12-09 22:15:11 UTC) #2
piman
10 years ago (2010-12-09 22:35:10 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698