Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 5720002: Merge 68816 - Fixes bug where we would show an instant preview when we though... (Closed)

Created:
10 years ago by sky
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 68816 - Fixes bug where we would show an instant preview when we thought the search engine supported instant but it doesn't. BUG=66133 TEST=covered by interactive ui test. You can also manually test Review URL: http://codereview.chromium.org/5771001 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -60 lines) Patch
M chrome/browser/instant/instant_browsertest.cc View 4 chunks +67 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 chunk +13 lines, -15 lines 0 comments Download
M chrome/browser/instant/instant_loader.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 3 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/instant/instant_loader_delegate.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/instant/instant_loader_manager_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
A + chrome/test/data/instant/empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
10 years ago (2010-12-10 02:36:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698