Issue 5771001: Fixes bug where we would show an instant preview when we thought the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5771001: Fixes bug where we would show an instant preview when we thought the (Closed)

Created:
10 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes bug where we would show an instant preview when we thought the search engine supported instant but it doesn't. BUG=66133 TEST=covered by interactive ui test. You can also manually test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68816

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -60 lines)			Patch
M	chrome/browser/instant/instant_browsertest.cc	View	4 chunks	+67 lines, -3 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.cc	View	1 chunk	+13 lines, -15 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.cc	View	3 chunks	+1 line, -23 lines	0 comments	Download
M	chrome/browser/instant/instant_loader_delegate.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/instant/instant_loader_manager_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
A	chrome/test/data/instant/empty.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

i looked over it, but the best I can do is rubber stamp

Expand Messages | Collapse Messages