Merge 68816 - Fixes bug where we would show an instant preview when we though...

chrome/browser/instant/instant_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_edit_view.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/location_bar.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
+#include "chrome/browser/renderer_host/render_widget_host_view.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_model.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents_wrapper.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 
 class InstantTest : public InProcessBrowserTest {
@@ skipping 26 matching lines @@
         page.c_str());
     template_url->SetURL(url, 0, 0);
     template_url->SetInstantURL(url, 0, 0);
     template_url->set_keyword(UTF8ToWide("foo"));
     template_url->set_short_name(UTF8ToWide("foo"));
 
     model->Add(template_url);
     model->SetDefaultSearchProvider(template_url);
   }
 
+  virtual void FindLocationBar() {
+    if (location_bar_)
+      return;
+    location_bar_ = browser()->window()->GetLocationBar();
+    ASSERT_TRUE(location_bar_);
+  }
+
   // Type a character to get instant to trigger.
   void SetupLocationBar() {
-    location_bar_ = browser()->window()->GetLocationBar();
-    ASSERT_TRUE(location_bar_);
+    FindLocationBar();
     location_bar_->location_entry()->SetUserText(L"a");
   }
 
   // Wait for instant to load and ensure it is in the state we expect.
   void SetupPreview() {
     preview_ = browser()->instant()->GetPreviewContents()->tab_contents();
     ASSERT_TRUE(preview_);
     ui_test_utils::WaitForNavigation(&preview_->controller());
 
     // Verify the initial setup of the search box.
@@ skipping 13 matching lines @@
         0, "window.onchangecalls", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
         0, "window.onresizecalls", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckStringValueFromJavascript(
         "a", "window.chrome.searchBox.value", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
         false, "window.chrome.searchBox.verbatim", preview_));
   }
 
   void SetLocationBarText(const std::wstring& text) {
-    ASSERT_TRUE(location_bar_);
+    ASSERT_NO_FATAL_FAILURE(FindLocationBar());
     location_bar_->location_entry()->SetUserText(text);
     ui_test_utils::WaitForNotification(
         NotificationType::INSTANT_CONTROLLER_SHOWN);
   }
 
   void SendKey(app::KeyboardCode key) {
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
         browser(), key, false, false, false, false));
   }
 
@@ skipping 62 matching lines @@
 
   // Check that the value is reflected and onchange is called.
   EXPECT_NO_FATAL_FAILURE(CheckStringValueFromJavascript(
       "abc", "window.chrome.searchBox.value", preview_));
   EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
       false, "window.chrome.searchBox.verbatim", preview_));
   EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
       1, "window.onchangecalls", preview_));
 }
 
+// Makes sure that if the server doesn't support the instant API we don't show
+// anything.
+IN_PROC_BROWSER_TEST_F(InstantTest, SearchServerDoesntSupportInstant) {
+  ASSERT_TRUE(test_server()->Start());
+  ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("empty.html"));
+  ASSERT_NO_FATAL_FAILURE(FindLocationBar());
+  location_bar_->location_entry()->SetUserText(L"a");
+  ASSERT_TRUE(browser()->instant());
+  // Because we typed in a search string we should think we're showing instant
+  // results.
+  EXPECT_TRUE(browser()->instant()->IsShowingInstant());
+  // But because we're waiting to determine if the page really supports instant
+  // we shouldn't be showing the preview.
+  EXPECT_FALSE(browser()->instant()->is_active());
+
+  // When the response comes back that the page doesn't support instant the tab
+  // should be closed.
+  ui_test_utils::WaitForNotification(NotificationType::TAB_CLOSED);
+  EXPECT_FALSE(browser()->instant()->IsShowingInstant());
+  EXPECT_FALSE(browser()->instant()->is_active());
+}
+
+// Verifies transitioning from loading a non-search string to a search string
+// with the provider not supporting instant works (meaning we don't display
+// anything).
+IN_PROC_BROWSER_TEST_F(InstantTest, NonSearchToSearchDoesntSupportInstant) {
+  ASSERT_TRUE(test_server()->Start());
+  ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("empty.html"));
+  GURL url(test_server()->GetURL("files/instant/empty.html"));
+  ASSERT_NO_FATAL_FAILURE(SetLocationBarText(UTF8ToWide(url.spec())));
+  // The preview should be active and showing.
+  ASSERT_TRUE(browser()->instant()->is_active());
+  TabContentsWrapper* initial_tab = browser()->instant()->GetPreviewContents();
+  ASSERT_TRUE(initial_tab);
+  RenderWidgetHostView* rwhv =
+      initial_tab->tab_contents()->GetRenderWidgetHostView();
+  ASSERT_TRUE(rwhv);
+  ASSERT_TRUE(rwhv->IsShowing());
+
+  // Now type in some search text.
+  location_bar_->location_entry()->SetUserText(L"a");
+
+  // Instant should still be live.
+  ASSERT_TRUE(browser()->instant()->is_active());
+  // Because we typed in a search string we should think we're showing instant
+  // results.
+  EXPECT_TRUE(browser()->instant()->MightSupportInstant());
+  // Instant should not be current (it's still loading).
+  EXPECT_FALSE(browser()->instant()->IsCurrent());
+
+  // When the response comes back that the page doesn't support instant the tab
+  // should be closed.
+  ui_test_utils::WaitForNotification(NotificationType::TAB_CLOSED);
+  EXPECT_FALSE(browser()->instant()->IsShowingInstant());
+  EXPECT_FALSE(browser()->instant()->is_active());
+}
+
 // Verify that the onsubmit event is dispatched upon pressing enter.
 // TODO(sky): Disabled, http://crbug.com/62940.
 IN_PROC_BROWSER_TEST_F(InstantTest, DISABLED_OnSubmitEvent) {
   ASSERT_TRUE(test_server()->Start());
   ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("search.html"));
   ASSERT_NO_FATAL_FAILURE(SetupLocationBar());
   ASSERT_NO_FATAL_FAILURE(SetupPreview());
 
   ASSERT_NO_FATAL_FAILURE(SetLocationBarText(L"abc"));
   ASSERT_NO_FATAL_FAILURE(SendKey(app::VKEY_RETURN));
@@ skipping 39 matching lines @@
   // Check that the value is reflected and oncancel is called.
   EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
       true, "window.chrome.sv", contents));
   EXPECT_NO_FATAL_FAILURE(CheckStringValueFromJavascript(
       "abc", "window.chrome.searchBox.value", contents));
   EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
       false, "window.chrome.searchBox.verbatim", contents));
   EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
       1, "window.oncancelcalls", contents));
 }