Fix extension packer command-line code for Mac

Fix extension packer command-line code for Mac. Instead of blocking in a janky way by running the message loop, I added an option to run the extension packer job synchronously.

One thing to note as it pertains to the bug report is that the path must be fully qualified. ~/ for home directories doesn't work for me.

BUG=65645
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69073

[Bons, 2010-12-13 13:30:57]

Hey Mark,
Maybe you can tell me what I'm doing that is so idiotic?

It's hanging on done_event_.Wait() within the extension_startup.cc impl. Should
I be calling Signal() on another thread?

Happy Monday.

[Mark Mentovai, 2010-12-13 20:44:46]

LG otherwise.

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/browser_main.cc
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/browser_main....
chrome/browser/browser_main.cc:1279: return ResultCodes::NORMAL_EXIT;
Check PackExtension’s return value and return something other than NORMAL_EXIT
if it failed?

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extensions_startup.cc (right):

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extensions_startup.cc:62: return true;
Allays true?

How ’bout false if someone called the failure callback instead of the success
one?

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
File chrome/browser/extensions/pack_extension_job.h (right):

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
chrome/browser/extensions/pack_extension_job.h:36: // Starts the packing job.
fudgey.

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
chrome/browser/extensions/pack_extension_job.h:47: void set_asynchronous(bool
async) { async_ = async; }
If the member is named async_, this should be set_async.

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
chrome/browser/extensions/pack_extension_job.h:54: // Depending on the value of
|async_|, this could be run on either the client
This still sounds like it’ll run on one thread or another. If async_ is false,
this will just run on whatever thread calls it. Say that?

[Bons, 2010-12-13 22:08:26]

Fixed these and the other issues mento and I talked about.

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
File chrome/browser/extensions/pack_extension_job.h (right):

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
chrome/browser/extensions/pack_extension_job.h:36: // Starts the packing job.
On 2010/12/13 20:44:46, Mark Mentovai wrote:
> fudgey.

Done.

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
chrome/browser/extensions/pack_extension_job.h:47: void set_asynchronous(bool
async) { async_ = async; }
On 2010/12/13 20:44:46, Mark Mentovai wrote:
> If the member is named async_, this should be set_async.

Done.

http://codereview.chromium.org/5703004/diff/6001/chrome/browser/extensions/pa...
chrome/browser/extensions/pack_extension_job.h:54: // Depending on the value of
|async_|, this could be run on either the client
On 2010/12/13 20:44:46, Mark Mentovai wrote:
> This still sounds like it’ll run on one thread or another. If async_ is false,
> this will just run on whatever thread calls it. Say that?

Done.

[Mark Mentovai, 2010-12-13 22:11:56]

LGTM

http://codereview.chromium.org/5703004/diff/11001/chrome/browser/extensions/p...
File chrome/browser/extensions/pack_extension_job.h (right):

http://codereview.chromium.org/5703004/diff/11001/chrome/browser/extensions/p...
chrome/browser/extensions/pack_extension_job.h:48: bool asynchronous() { return
asynchronous_; }
Should be
  bool asynchronous() const { return asynchronous_; }
but it’s not used so you can also just get rid of it.

[Aaron Boodman, 2010-12-13 23:37:45]

I like this solution. Let me know if you want me to review something in
particular.