Fix extension packer command-line code for Mac

chrome/browser/extensions/pack_extension_job.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_
 #define CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_
 #pragma once
 
 #include <string>
 
@@ skipping 15 matching lines @@
     virtual void OnPackFailure(const std::string& message) = 0;
 
    protected:
     virtual ~Client() {}
   };
 
   PackExtensionJob(Client* client,
                    const FilePath& root_directory,
                    const FilePath& key_file);
 
-  // Starts the packing thread job. See http://crbug.com/27944 for more details
-  // on why this function is needed.
+  // Starts the packing job.

[Mark Mentovai, 2010/12/13 20:44:46]

fudgey.

[Bons, 2010/12/13 22:08:27]

Done.

   void Start();
 
   // The client should call this when it is destroyed to prevent
   // PackExtensionJob from attempting to access it.
   void ClearClient();
 
   // The standard packing success message.
   static std::wstring StandardSuccessMessage(const FilePath& crx_file,
                                              const FilePath& key_file);
 
+  void set_asynchronous(bool async) { async_ = async; }

[Mark Mentovai, 2010/12/13 20:44:46]

If the member is named async_, this should be set_async.

[Bons, 2010/12/13 22:08:27]

Done.

+
  private:
   friend class base::RefCountedThreadSafe<PackExtensionJob>;
 
   virtual ~PackExtensionJob();
 
-  void RunOnFileThread();
+  // Depending on the value of |async_|, this could be run on either the client

[Mark Mentovai, 2010/12/13 20:44:46]

This still sounds like it’ll run on one thread or another. If async_ is false,
this will just run on whatever thread calls it. Say that?

[Bons, 2010/12/13 22:08:27]

Done.

+  // or file thread.
+  void Run();
   void ReportSuccessOnClientThread();
   void ReportFailureOnClientThread(const std::string& error);
 
   BrowserThread::ID client_thread_id_;
   Client* client_;
   FilePath root_directory_;
   FilePath key_file_;
   FilePath crx_file_out_;
   FilePath key_file_out_;
+  bool async_;
 
   DISALLOW_COPY_AND_ASSIGN(PackExtensionJob);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_