Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: chrome/browser/extensions/pack_extension_job.h

Issue 5703004: Fix extension packer command-line code for Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed mento's comments and fixed win compile error. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_startup.cc ('k') | chrome/browser/extensions/pack_extension_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/pack_extension_job.h
diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h
index ecd3d68a91d76ad59f3fa53a87f247bdfffe9fff..925f12e0a2df387901a92aa7c2d167665406b4ef 100644
--- a/chrome/browser/extensions/pack_extension_job.h
+++ b/chrome/browser/extensions/pack_extension_job.h
@@ -33,8 +33,7 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
const FilePath& root_directory,
const FilePath& key_file);
- // Starts the packing thread job. See http://crbug.com/27944 for more details
- // on why this function is needed.
+ // Starts the packing job.
void Start();
// The client should call this when it is destroyed to prevent
@@ -45,12 +44,16 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
static std::wstring StandardSuccessMessage(const FilePath& crx_file,
const FilePath& key_file);
+ void set_asynchronous(bool async) { asynchronous_ = async; }
+ bool asynchronous() { return asynchronous_; }
Mark Mentovai 2010/12/13 22:11:57 Should be bool asynchronous() const { return asy
+
private:
friend class base::RefCountedThreadSafe<PackExtensionJob>;
virtual ~PackExtensionJob();
- void RunOnFileThread();
+ // If |asynchronous_| is false, this is run on whichever thread calls it.
+ void Run();
void ReportSuccessOnClientThread();
void ReportFailureOnClientThread(const std::string& error);
@@ -60,6 +63,7 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
FilePath key_file_;
FilePath crx_file_out_;
FilePath key_file_out_;
+ bool asynchronous_;
DISALLOW_COPY_AND_ASSIGN(PackExtensionJob);
};
« no previous file with comments | « chrome/browser/extensions/extensions_startup.cc ('k') | chrome/browser/extensions/pack_extension_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698