cashew: add cros-debug support

cashew: add cros-debug support

DCHECK macro in default clause of switch statement is compiled out when
cashew is compiled NDEBUG, causing a compilation error. Replace with a
CHECK macro.

Uncomment use of google::ShutdownGoogleLogging now that we have updated
glog to version 0.3.1 (see issue 8823).

BUG=chromium-os:8800
TEST=USE=-cros-debug emerge-<board> cashew

Change-Id: Ib60933ca908c2d383e6e241fcf77c2e32e8b92f9

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2976dae

[Vince Laviano, 2010-12-14 02:14:12]

Related CL for cashew ebuild: http://codereview.chromium.org/5718004/

[Daniel Kurtz, 2010-12-14 04:38:43]

tiny questions

http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc
File src/data_plan.cc (right):

http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc#newcode309
src/data_plan.cc:309: DCHECK(plan != NULL);
CHECK_NOTNULL(plan)?

http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc#newcode328
src/data_plan.cc:328: CHECK(false);
Is it ok to not return anything here?

[Vince Laviano, 2010-12-14 18:48:22]

http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc
File src/data_plan.cc (right):

http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc#newcode309
src/data_plan.cc:309: DCHECK(plan != NULL);
On 2010/12/14 04:38:44, djkurtz wrote:
> CHECK_NOTNULL(plan)?

I wanted this to be a debug-only check. The version of glog that we were using
at the time of writing had no DCHECK_NOTNULL macro, so I used the more general
DCHECK macro instead.  However, DCHECK_NOTNULL was added in glog 0.3.1, so I'll
update this code to use it.

http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc#newcode328
src/data_plan.cc:328: CHECK(false);
On 2010/12/14 04:38:44, djkurtz wrote:
> Is it ok to not return anything here?

Yes, if we're aborting unconditionally. The reason for aborting is because this
is a "can't happen" scenario and there's nothing sensible to return here. 

g++ is ok with this in -Wall -Werror mode.

[Daniel Kurtz, 2010-12-14 18:56:20]

LGTM

On 2010/12/14 18:48:22, Vince Laviano wrote:
> http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc
> File src/data_plan.cc (right):
> 
> http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc#newcode309
> src/data_plan.cc:309: DCHECK(plan != NULL);
> On 2010/12/14 04:38:44, djkurtz wrote:
> > CHECK_NOTNULL(plan)?
> 
> I wanted this to be a debug-only check. The version of glog that we were using
> at the time of writing had no DCHECK_NOTNULL macro, so I used the more general
> DCHECK macro instead.  However, DCHECK_NOTNULL was added in glog 0.3.1, so
I'll
> update this code to use it.
> 
> http://codereview.chromium.org/5696004/diff/1/src/data_plan.cc#newcode328
> src/data_plan.cc:328: CHECK(false);
> On 2010/12/14 04:38:44, djkurtz wrote:
> > Is it ok to not return anything here?
> 
> Yes, if we're aborting unconditionally. The reason for aborting is because
this
> is a "can't happen" scenario and there's nothing sensible to return here. 
> 
> g++ is ok with this in -Wall -Werror mode.