src/data_plan.cc - Issue 5696004: cashew: add cros-debug support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/data_plan.cc

Issue 5696004: cashew: add cros-debug support (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/cashew.git@master

Patch Set: Address djkurtz review comments Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/data_plan.cc

diff --git a/src/data_plan.cc b/src/data_plan.cc

index e6c5a7198fb8b61239dc1ccac65cc4952195f155..ca58fb31241a395ef42929ed6d3156e1ba52db33 100644

--- a/src/data_plan.cc

+++ b/src/data_plan.cc

@@ -306,7 +306,7 @@ DataPlan* DataPlan::GetActivePlan(const DataPlanList& data_plans) {

DataPlanList::const_iterator it;

for (it = data_plans.begin(); it != data_plans.end(); ++it) {

DataPlan *plan = *it;

- DCHECK(plan != NULL);

+ DCHECK_NOTNULL(plan);

if (plan->IsActive()) {

return plan;

}

@@ -325,7 +325,7 @@ const char* DataPlan::TypeToLibcrosString(DataPlan::Type type) const {

case kTypeMeteredPaid:

return kCellularDataPlanTypeMeteredPaid;

default:

- DCHECK(false);

+ CHECK(false);

}

« no previous file with comments | « no previous file | src/main.cc » ('j') | no next file with comments »