Issue 5718004: cashew ebuild: add cros-debug support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5718004: cashew ebuild: add cros-debug support (Closed)

Created:
10 years ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Daniel Kurtz

CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr, anush

Base URL:
ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git@master

Visibility:
Public.

Description

cashew ebuild: add cros-debug support BUG=chromium-os:8800 TEST=emerge cashew with and without USE=-cros-debug Change-Id: I11e666f28215150d59dc086702e774016c90f990 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dfdb741

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	chromeos-base/cashew/cashew-9999.ebuild	View		3 chunks	+9 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vince Laviano

Related CL for cashew: http://codereview.chromium.org/5696004/

10 years ago (2010-12-14 02:14:50 UTC) #1

Daniel Kurtz

LGTM w/ optional nit. http://codereview.chromium.org/5718004/diff/1/chromeos-base/cashew/cashew-9999.ebuild File chromeos-base/cashew/cashew-9999.ebuild (right): http://codereview.chromium.org/5718004/diff/1/chromeos-base/cashew/cashew-9999.ebuild#newcode34 chromeos-base/cashew/cashew-9999.ebuild:34: econf || die "econf failed" ...

10 years ago (2010-12-14 04:14:21 UTC) #2

Vince Laviano

10 years ago (2010-12-14 21:16:28 UTC) #3

http://codereview.chromium.org/5718004/diff/1/chromeos-base/cashew/cashew-999...
File chromeos-base/cashew/cashew-9999.ebuild (right):

http://codereview.chromium.org/5718004/diff/1/chromeos-base/cashew/cashew-999...
chromeos-base/cashew/cashew-9999.ebuild:34: econf || die "econf failed"
On 2010/12/14 04:14:21, djkurtz wrote:
> It seems that most other ebuilds don't die on econf fail... but, I don't know
> why.

I suspect that die clauses are only needed to return early and avoid executing
subsequent lines in the ebuild. However, I like the uniform error messaging
across the various ebuild functions, so I'm inclined to keep it.

Expand Messages | Collapse Messages