Issue 5695007: Enhance RunPylint to use white_list and black_list arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5695007: Enhance RunPylint to use white_list and black_list arguments. (Closed)

Created:
10 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Enhance RunPylint to use white_list and black_list arguments. Change RunPylint to parse all .py files when one is modified. Make all depot_tools/tests pass on pylint. That mostly meant fixing some builtins aliasing, wrong alignment and turning off most remaining warnings. BUG=none TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69159

Patch Set 1 #

Total comments: 1

Patch Set 2 : address review comment #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -114 lines)			Patch
M	PRESUBMIT.py	View		1 chunk	+5 lines, -8 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1	1 chunk	+38 lines, -7 lines	0 comments	Download
M	pylintrc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/fake_repos.py	View		5 chunks	+8 lines, -5 lines	0 comments	Download
M	tests/gcl_unittest.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/gclient_scm_test.py	View		9 chunks	+12 lines, -14 lines	0 comments	Download
M	tests/gclient_smoketest.py	View		6 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	tests/presubmit_unittest.py	View		24 chunks	+58 lines, -52 lines	0 comments	Download
M	tests/scm_unittest.py	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/super_mox.py	View		7 chunks	+8 lines, -7 lines	0 comments	Download
M	tests/trychange_unittest.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/watchlists_unittest.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

The only important files are PRESUBMIT.py and presubmit_canned_checks.py. The rest is mostly side effects from ...

10 years ago (2010-12-14 17:29:44 UTC) #1

Evan Martin

10 years ago (2010-12-14 17:41:14 UTC) #2

LGTM

http://codereview.chromium.org/5695007/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/5695007/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:472: # files on each single python change. It's
because a change in a python file
s/files/file

Expand Messages | Collapse Messages