Enhance RunPylint to use white_list and black_list arguments.

tests/fake_repos.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generate fake repositories for testing."""
 
 import atexit
 import errno
 import logging
@@ skipping 10 matching lines @@
 
 import scm
 
 ## Utility functions
 
 
 def addKill():
   """Add kill() method to subprocess.Popen for python <2.6"""
   if getattr(subprocess.Popen, 'kill', None):
     return
+  # Unable to import 'module'
+  # pylint: disable=F0401
   if sys.platform == 'win32':
     def kill_win(process):
       import win32process
+      # Access to a protected member _handle of a client class
+      # pylint: disable=W0212
       return win32process.TerminateProcess(process._handle, -1)
     subprocess.Popen.kill = kill_win
   else:
     def kill_nix(process):
       import signal
       return os.kill(process.pid, signal.SIGKILL)
     subprocess.Popen.kill = kill_nix
 
 
 def rmtree(*path):
@@ skipping 118 matching lines @@
     elif status[0] == '!':
       to_remove.append(filepath)
   if to_add:
     check_call(['svn', 'add', '--no-auto-props', '-q'] + to_add, cwd=repo)
   if to_remove:
     check_call(['svn', 'remove', '-q'] + to_remove, cwd=repo)
   proc = Popen(['svn', 'commit', repo, '-m', 'foo', '--non-interactive',
                 '--no-auth-cache', '--username', 'user1', '--password', 'foo'],
                cwd=repo)
   out, err = proc.communicate()
-  last_line = out.splitlines()[-1]
   match = re.search(r'(\d+)', out)
   if not match:
     raise Exception('Commit failed', out, err, proc.returncode)
   rev = match.group(1)
   st = Popen(['svn', 'status'], cwd=repo).communicate()[0]
   assert len(st) == 0, st
   logging.debug('At revision %s' % rev)
   return rev
 
 
@@ skipping 77 matching lines @@
       self.svnserve.kill()
       self.svnserve = None
     if self.gitdaemon:
       logging.debug('Killing git-daemon pid %s' % self.gitdaemon.pid)
       self.gitdaemon.kill()
       self.gitdaemon = None
     if not self.SHOULD_LEAK:
       logging.debug('Removing %s' % self.trial_dir())
       rmtree(self.trial_dir())
 
-  def _genTree(self, root, tree_dict):
+  @staticmethod
+  def _genTree(root, tree_dict):
     """For a dictionary of file contents, generate a filesystem."""
     if not os.path.isdir(root):
       os.makedirs(root)
     for (k, v) in tree_dict.iteritems():
       k_os = k.replace('/', os.sep)
       k_arr = k_os.split(os.sep)
       if len(k_arr) > 1:
         p = os.sep.join([root] + k_arr[:-1])
         if not os.path.isdir(p):
           os.makedirs(p)
       if v is None:
         os.remove(join(root, k))
       else:
         write(join(root, k), v)
 
   def setUpSVN(self):
     """Creates subversion repositories and start the servers."""
     if self.svnserve:
       return True
     self.setUp()
     root = join(self.repos_dir, 'svn')
     try:
       check_call(['svnadmin', 'create', root])
     except OSError:
-      self.svn_enabled = False
       return False
     write(join(root, 'conf', 'svnserve.conf'),
         '[general]\n'
         'anon-access = read\n'
         'auth-access = write\n'
         'password-db = passwd\n')
     write(join(root, 'conf', 'passwd'),
         '[users]\n'
         'user1 = foo\n'
         'user2 = bar\n')
@@ skipping 235 matching lines @@
     if self.svn_revs and self.svn_revs[-1]:
       new_tree = self.svn_revs[-1].copy()
       new_tree.update(tree)
     else:
       new_tree = tree.copy()
     self.svn_revs.append(new_tree)
 
   def _commit_git(self, repo, tree):
     repo_root = join(self.git_root, repo)
     self._genTree(repo_root, tree)
-    hash = commit_git(repo_root)
+    commit_hash = commit_git(repo_root)
     if self.git_hashes[repo][-1]:
       new_tree = self.git_hashes[repo][-1][1].copy()
       new_tree.update(tree)
     else:
       new_tree = tree.copy()
-    self.git_hashes[repo].append((hash, new_tree))
+    self.git_hashes[repo].append((commit_hash, new_tree))
 
 
 class FakeReposTestBase(unittest.TestCase):
   """This is vaguely inspired by twisted."""
 
   # Replace this in your subclass.
   CLASS_ROOT_DIR = None
 
   # static FakeRepos instance. Lazy loaded.
   FAKE_REPOS = None
@@ skipping 99 matching lines @@
 
 
 # Kind of hack.
 if '-l' in sys.argv:
   FakeRepos.SHOULD_LEAK = True
   sys.argv.remove('-l')
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))