Enhance RunPylint to use white_list and black_list arguments.

tests/gclient_smoketest.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Smoke tests for gclient.py.
 
 Shell out 'gclient' and run basic conformance tests.
 
 This test assumes GClientSmokeBase.URL_BASE is valid.
 """
 
+# pylint: disable=E1103,W0403
+
 import logging
 import os
 import re
 import subprocess
 import sys
 import unittest
 
 from fake_repos import check_call, join, write, FakeReposTestBase
 
 GCLIENT_PATH = join(os.path.dirname(os.path.dirname(os.path.abspath(__file__))),
@@ skipping 97 matching lines @@
         verb = items[i][0]
         path = items[i][1]
       else:
         verb = items[i]
         path = self.root_dir
       self.checkString(results[i][0][0], verb, (i, results[i][0][0], verb))
       self.checkString(results[i][0][2], path, (i, results[i][0][2], path))
     self.assertEquals(len(results), len(items), (stdout, items, len(results)))
     return results
 
-  def svnBlockCleanup(self, out):
+  @staticmethod
+  def svnBlockCleanup(out):
     """Work around svn status difference between svn 1.5 and svn 1.6
     I don't know why but on Windows they are reversed. So sorts the items."""
     for i in xrange(len(out)):
       if len(out[i]) < 2:
         continue
       out[i] = [out[i][0]] + sorted([x[1:].strip() for x in out[i][1:]])
     return out
 
 
 class GClientSmoke(GClientSmokeBase):
@@ skipping 512 matching lines @@
     src = join(self.root_dir, 'src')
     res = self.gclient(['status', '--jobs', '1'], src)
     self.checkBlock(res[0], [('running', src)])
 
   def testInitialCheckoutNotYetDone(self):
     # Check that gclient can be executed when the initial checkout hasn't been
     # done yet.
     if not self.enabled:
       return
     self.gclient(['config', self.svn_base + 'trunk/src/'])
-    self.parseGclient(['sync', '--jobs', '1'],
-                      ['running', 'running',
-                       # This is due to the way svn update is called for a
-                       # single file when File() is used in a DEPS file.
-                       ('running', os.path.join(self.root_dir, 'src', 'file', 'other')),
-                       'running', 'running', 'running', 'running'])
+    self.parseGclient(
+        ['sync', '--jobs', '1'],
+        ['running', 'running',
+         # This is due to the way svn update is called for a
+         # single file when File() is used in a DEPS file.
+         ('running', os.path.join(self.root_dir, 'src', 'file', 'other')),
+         'running', 'running', 'running', 'running'])
 
   def testInitialCheckoutFailed(self):
     # Check that gclient can be executed from an arbitrary sub directory if the
     # initial checkout has failed.
     if not self.enabled:
       return
     self.gclient(['config', self.svn_base + 'trunk/src/'])
     self.gclient(['sync'])
     # Cripple the checkout.
     os.remove(join(self.root_dir, '.gclient_entries'))
@@ skipping 197 matching lines @@
     if not self.enabled:
       return
     self.gclient(['config', self.git_base + 'repo_1', '--name', 'src'])
     self.gclient(['sync', '--deps', 'mac'])
     results = self.gclient(['revinfo', '--deps', 'mac'])
     out = ('src: %(base)srepo_1\n'
            'src/repo2: %(base)srepo_2@%(hash2)s\n'
            'src/repo2/repo_renamed: %(base)srepo_3\n' %
           {
             'base': self.git_base,
-            'hash1': self.githash('repo_1', 2)[:7],
             'hash2': self.githash('repo_2', 1)[:7],
-            'hash3': self.githash('repo_3', 2)[:7],
           })
     self.check((out, '', 0), results)
     results = self.gclient(['revinfo', '--deps', 'mac', '--actual'])
     out = ('src: %(base)srepo_1@%(hash1)s\n'
            'src/repo2: %(base)srepo_2@%(hash2)s\n'
            'src/repo2/repo_renamed: %(base)srepo_3@%(hash3)s\n' %
           {
             'base': self.git_base,
             'hash1': self.githash('repo_1', 2),
             'hash2': self.githash('repo_2', 1),
@@ skipping 106 matching lines @@
     results = self.gclient(['revinfo', '--deps', 'mac'])
     out = ('src: %(svn_base)s/src/\n'
            'src-git: %(git_base)srepo_1\n'
            'src/file/other: File("%(svn_base)s/other/DEPS")\n'
            'src/other: %(svn_base)s/other\n'
            'src/repo2: %(git_base)srepo_2@%(hash2)s\n'
            'src/repo2/repo_renamed: %(git_base)srepo_3\n'
            'src/third_party/foo: %(svn_base)s/third_party/foo@1\n') % {
                'svn_base': self.svn_base + 'trunk',
                'git_base': self.git_base,
-               'hash1': self.githash('repo_1', 2)[:7],
                'hash2': self.githash('repo_2', 1)[:7],
-               'hash3': self.githash('repo_3', 2)[:7],
           }
     self.check((out, '', 0), results)
     results = self.gclient(['revinfo', '--deps', 'mac', '--actual'])
     out = ('src: %(svn_base)s/src/@2\n'
            'src-git: %(git_base)srepo_1@%(hash1)s\n'
            'src/file/other: %(svn_base)s/other/DEPS@2\n'
            'src/other: %(svn_base)s/other@2\n'
            'src/repo2: %(git_base)srepo_2@%(hash2)s\n'
            'src/repo2/repo_renamed: %(git_base)srepo_3@%(hash3)s\n'
            'src/third_party/foo: %(svn_base)s/third_party/foo@1\n') % {
@@ skipping 114 matching lines @@
     #expected = (
     #    './: None\nfoo/bar: svn://127.0.0.1/svn/trunk/third_party/foo@1\n',
     #    '', 0)
     #self.check(expected, results)
 
   def testRest(self):
     if not self.enabled:
       return
     self.gclient(['sync'])
     # TODO(maruel): This is incorrect, it should run on ./ too.
-    out = self.parseGclient(
+    self.parseGclient(
         ['cleanup', '--deps', 'mac', '--verbose', '--jobs', '1'],
         [('running', join(self.root_dir, 'foo', 'bar'))])
-    out = self.parseGclient(
+    self.parseGclient(
         ['diff', '--deps', 'mac', '--verbose', '--jobs', '1'],
         [('running', join(self.root_dir, 'foo', 'bar'))])
 
 
 if __name__ == '__main__':
   if '-c' in sys.argv:
     COVERAGE = True
     sys.argv.remove('-c')
     if os.path.exists('.coverage'):
       os.remove('.coverage')
     os.environ['COVERAGE_FILE'] = os.path.join(
         os.path.dirname(os.path.dirname(os.path.abspath(__file__))),
         '.coverage')
   unittest.main()