Issue 569008: Remember to update the write barrier when storing into...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 569008: Remember to update the write barrier when storing into... (Closed)

Created:
10 years, 10 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remember to update the write barrier when storing into the context in the full compiler. Clobber all input registers in the RecordWrite code when the debug-code flag is set. Committed: http://code.google.com/p/v8/source/detail?r=3761

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -22 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		3 chunks	+10 lines, -4 lines	2 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		3 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

STV! http://codereview.chromium.org/569008/diff/4001/1002 File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/569008/diff/4001/1002#newcode54 src/ia32/full-codegen-ia32.cc:54: void FullCodeGenerator::Generate(FunctionLiteral* fun', Mode mode) { Accidental edit?

10 years, 10 months ago (2010-02-02 07:51:15 UTC) #2

Lasse Reichstein

10 years, 10 months ago (2010-02-02 07:51:33 UTC) #3

LGTM!

http://codereview.chromium.org/569008/diff/4001/1002
File src/ia32/full-codegen-ia32.cc (right):

http://codereview.chromium.org/569008/diff/4001/1002#newcode54
src/ia32/full-codegen-ia32.cc:54: void
FullCodeGenerator::Generate(FunctionLiteral* fun', Mode mode) {
Typo '.

Expand Messages | Collapse Messages