Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 569008: Remember to update the write barrier when storing into... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 // record write code isn't going to save us any memory. 208 // record write code isn't going to save us any memory.
209 if (generating_stub()) { 209 if (generating_stub()) {
210 RecordWriteHelper(this, object, dst, value); 210 RecordWriteHelper(this, object, dst, value);
211 } else { 211 } else {
212 RecordWriteStub stub(object, dst, value); 212 RecordWriteStub stub(object, dst, value);
213 CallStub(&stub); 213 CallStub(&stub);
214 } 214 }
215 } 215 }
216 216
217 bind(&done); 217 bind(&done);
218
219 // Clobber all input registers when running with the debug-code flag
220 // turned on to provoke errors.
221 if (FLAG_debug_code) {
222 mov(object, Immediate(bit_cast<int32_t>(kZapValue)));
223 mov(value, Immediate(bit_cast<int32_t>(kZapValue)));
224 mov(scratch, Immediate(bit_cast<int32_t>(kZapValue)));
225 }
218 } 226 }
219 227
220 228
221 void MacroAssembler::StackLimitCheck(Label* on_stack_overflow) { 229 void MacroAssembler::StackLimitCheck(Label* on_stack_overflow) {
222 cmp(esp, 230 cmp(esp,
223 Operand::StaticVariable(ExternalReference::address_of_stack_limit())); 231 Operand::StaticVariable(ExternalReference::address_of_stack_limit()));
224 j(below, on_stack_overflow); 232 j(below, on_stack_overflow);
225 } 233 }
226 234
227 235
(...skipping 1355 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 // Indicate that code has changed. 1591 // Indicate that code has changed.
1584 CPU::FlushICache(address_, size_); 1592 CPU::FlushICache(address_, size_);
1585 1593
1586 // Check that the code was patched as expected. 1594 // Check that the code was patched as expected.
1587 ASSERT(masm_.pc_ == address_ + size_); 1595 ASSERT(masm_.pc_ == address_ + size_);
1588 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 1596 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
1589 } 1597 }
1590 1598
1591 1599
1592 } } // namespace v8::internal 1600 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698