Issue 5665: Replaces two non-private uses of AddProperty with IgnoreAttributesAndSetLocal...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5665: Replaces two non-private uses of AddProperty with IgnoreAttributesAndSetLocal... (Closed)

Created:
12 years, 2 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
olehougaard

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Replaces two non-private uses of AddProperty with IgnoreAttributesAndSetLocalProperty. Adds attributes parameter to IgnoreAtt..Property(). Makes IgnoreAtt..Property() an exact clone of SetProperty(), with explicit changes. Committed: http://code.google.com/p/v8/source/detail?r=411

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -57 lines)			Patch
M	src/accessors.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/handles.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/handles.cc	View	1	2 chunks	+10 lines, -9 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+81 lines, -38 lines	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Please review this change for me.  Thanx.

Expand Messages | Collapse Messages