Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Side by Side Diff: src/handles.cc

Issue 5665: Replaces two non-private uses of AddProperty with IgnoreAttributesAndSetLocal... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 130
131 Handle<Object> SetPrototype(Handle<JSFunction> function, 131 Handle<Object> SetPrototype(Handle<JSFunction> function,
132 Handle<Object> prototype) { 132 Handle<Object> prototype) {
133 CALL_HEAP_FUNCTION(Accessors::FunctionSetPrototype(*function, 133 CALL_HEAP_FUNCTION(Accessors::FunctionSetPrototype(*function,
134 *prototype, 134 *prototype,
135 NULL), 135 NULL),
136 Object); 136 Object);
137 } 137 }
138 138
139 139
140 void AddProperty(Handle<JSObject> object,
141 Handle<String> key,
142 Handle<Object> value,
143 PropertyAttributes attributes) {
144 CALL_HEAP_FUNCTION_VOID(object->AddProperty(*key, *value, attributes));
145 }
146
147 Handle<Object> SetProperty(Handle<JSObject> object, 140 Handle<Object> SetProperty(Handle<JSObject> object,
148 Handle<String> key, 141 Handle<String> key,
149 Handle<Object> value, 142 Handle<Object> value,
150 PropertyAttributes attributes) { 143 PropertyAttributes attributes) {
151 CALL_HEAP_FUNCTION(object->SetProperty(*key, *value, attributes), Object); 144 CALL_HEAP_FUNCTION(object->SetProperty(*key, *value, attributes), Object);
152 } 145 }
153 146
154 147
155 Handle<Object> SetProperty(Handle<Object> object, 148 Handle<Object> SetProperty(Handle<Object> object,
156 Handle<Object> key, 149 Handle<Object> key,
157 Handle<Object> value, 150 Handle<Object> value,
158 PropertyAttributes attributes) { 151 PropertyAttributes attributes) {
159 CALL_HEAP_FUNCTION(Runtime::SetObjectProperty(object, key, value, attributes), 152 CALL_HEAP_FUNCTION(
160 Object); 153 Runtime::SetObjectProperty(object, key, value, attributes), Object);
161 } 154 }
162 155
163 156
157 Handle<Object> IgnoreAttributesAndSetLocalProperty(Handle<JSObject> object,
158 Handle<String> key,
159 Handle<Object> value,
160 PropertyAttributes attributes) {
161 CALL_HEAP_FUNCTION(object->
162 IgnoreAttributesAndSetLocalProperty(*key, *value, attributes), Object);
163 }
164
164 Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object, 165 Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object,
165 Handle<String> key, 166 Handle<String> key,
166 Handle<Object> value, 167 Handle<Object> value,
167 PropertyAttributes attributes) { 168 PropertyAttributes attributes) {
168 CALL_HEAP_FUNCTION(object->SetPropertyWithInterceptor(*key, 169 CALL_HEAP_FUNCTION(object->SetPropertyWithInterceptor(*key,
169 *value, 170 *value,
170 attributes), 171 attributes),
171 Object); 172 Object);
172 } 173 }
173 174
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
543 Handle<Context> security_context) { 544 Handle<Context> security_context) {
544 Handle<FixedArray> arr = Factory::NewFixedArray(4); 545 Handle<FixedArray> arr = Factory::NewFixedArray(4);
545 arr->set(0, Smi::FromInt(index)); 546 arr->set(0, Smi::FromInt(index));
546 arr->set(1, *compile_context); // Compile in this context 547 arr->set(1, *compile_context); // Compile in this context
547 arr->set(2, *function_context); // Set function context to this 548 arr->set(2, *function_context); // Set function context to this
548 arr->set(3, *security_context); // Receiver for call 549 arr->set(3, *security_context); // Receiver for call
549 fun->shared()->set_lazy_load_data(*arr); 550 fun->shared()->set_lazy_load_data(*arr);
550 } 551 }
551 552
552 } } // namespace v8::internal 553 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698