Issue 566019: Implements glGetUniformiv and glGetUniformfv.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 566019: Implements glGetUniformiv and glGetUniformfv. (Closed)

Created:
10 years, 10 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implements glGetUniformiv and glGetUniformfv. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37918

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -28 lines)			Patch
M	gpu/command_buffer/client/gles2_implementation.cc	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	7 chunks	+134 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1	8 chunks	+216 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

10 years, 10 months ago (2010-02-02 22:04:10 UTC) #2

lgtm

http://codereview.chromium.org/566019/diff/1/3
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/566019/diff/1/3#newcode464
gpu/command_buffer/service/gles2_cmd_decoder.cc:464: name_buffer.reset(new
char[max_len]);
max_len + 1?

http://codereview.chromium.org/566019/diff/1/2
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right):

http://codereview.chromium.org/566019/diff/1/2#newcode27
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:27: GLsizei
GetGLDataTypeSize(GLenum type) {
You have this function duplicated in two different places.

Expand Messages | Collapse Messages