Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 566008: Incorporate the arguments to the code generator constructors and their (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Incorporate the arguments to the code generator constructors and their MakeCode functions in the CompilationInfo structure. This makes it easier to add new arguments and makes all arguments uniformly available to the various backends. Committed: http://code.google.com/p/v8/source/detail?r=3789

Patch Set 1 #

Patch Set 2 : Remove inadvertently included files. #

Total comments: 2

Patch Set 3 : Incorporate the arguments to the code generator constructors and their... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -400 lines) Patch
M src/arm/codegen-arm.h View 1 2 5 chunks +11 lines, -18 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 2 16 chunks +32 lines, -41 lines 0 comments Download
M src/arm/fast-codegen-arm.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 14 chunks +22 lines, -20 lines 0 comments Download
M src/codegen.cc View 1 2 5 chunks +22 lines, -20 lines 0 comments Download
M src/codegen-inl.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler.h View 1 2 1 chunk +91 lines, -12 lines 0 comments Download
M src/compiler.cc View 1 2 13 chunks +25 lines, -40 lines 0 comments Download
M src/data-flow.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M src/data-flow.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/fast-codegen.h View 1 2 3 chunks +6 lines, -17 lines 0 comments Download
M src/fast-codegen.cc View 1 2 5 chunks +14 lines, -17 lines 0 comments Download
M src/full-codegen.h View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M src/handles.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 2 6 chunks +12 lines, -17 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 19 chunks +36 lines, -44 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 13 chunks +22 lines, -20 lines 0 comments Download
M src/x64/codegen-x64.h View 1 2 6 chunks +12 lines, -18 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 2 21 chunks +37 lines, -44 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 13 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
This is not as big as it looks. Many of the changes are using an ...
10 years, 10 months ago (2010-02-02 01:53:12 UTC) #1
Mads Ager (chromium)
LGTM. http://codereview.chromium.org/566008/diff/1001/2008 File src/compiler.h (right): http://codereview.chromium.org/566008/diff/1001/2008#newcode140 src/compiler.h:140: FunctionLiteral* syntax_; I don't like the name 'syntax' ...
10 years, 10 months ago (2010-02-02 08:15:17 UTC) #2
fschneider
10 years, 10 months ago (2010-02-02 11:28:21 UTC) #3
LGTM.

http://codereview.chromium.org/566008/diff/1001/2008
File src/compiler.h (right):

http://codereview.chromium.org/566008/diff/1001/2008#newcode148
src/compiler.h:148: bool has_globals_;
Style question: What is the our convention for disallowing copy constructors? Do
we need DISALLOW_COPY_AND_ASSIGN here?

Powered by Google App Engine
This is Rietveld 408576698