Issue 558026: Fix the regexp in DEFAULT_WHITE_LIST.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558026: Fix the regexp in DEFAULT_WHITE_LIST. (Closed)

Created:
10 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix the regexp in DEFAULT_WHITE_LIST. For example, r".*\.c" was triggering for foo.checksum. TEST=none BUG=none

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	presubmit_support.py	View		1 chunk	+5 lines, -5 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 11 months ago (2010-01-28 23:41:47 UTC) #2

LGTM

http://codereview.chromium.org/558026/diff/1/2
File presubmit_support.py (right):

http://codereview.chromium.org/558026/diff/1/2#newcode159
presubmit_support.py:159: r"(^|.*?[\\\/])[^.]+$",
Surprised this is needed, since .* matches the empty string anyway...

http://codereview.chromium.org/558026/diff/1/2#newcode312
presubmit_support.py:312: if self.re.match(item, local_path):
Could also just add a "$" here to make match() mean "match the whole string".

Expand Messages | Collapse Messages