Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: presubmit_support.py

Issue 558026: Fix the regexp in DEFAULT_WHITE_LIST. (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index b6327621df796c3c630ce75191bd7a44ac168e76..5853e0b3d30f930011ac142196caa4f8764c0fff 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -150,15 +150,15 @@ class InputApi(object):
# perspective. Don't modify this list from a presubmit script!
DEFAULT_WHITE_LIST = (
# C++ and friends
- r".*\.c", r".*\.cc", r".*\.cpp", r".*\.h", r".*\.m", r".*\.mm",
- r".*\.inl", r".*\.asm", r".*\.hxx", r".*\.hpp",
+ r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
+ r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$",
# Scripts
- r".*\.js", r".*\.py", r".*\.sh", r".*\.rb", r".*\.pl", r".*\.pm",
+ r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
# No extension at all, note that ALL CAPS files are black listed in
# DEFAULT_BLACK_LIST below.
- r"(^|.*[\\\/])[^.]+$",
+ r"(^|.*?[\\\/])[^.]+$",
Evan Martin 2010/01/28 23:41:47 Surprised this is needed, since .* matches the emp
# Other
- r".*\.java", r".*\.mk", r".*\.am",
+ r".*\.java$", r".*\.mk$", r".*\.am$",
)
# Path regexp that should be excluded from being considered containing source
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698