Fix the regexp in DEFAULT_WHITE_LIST.

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.4'
 
@@ skipping 132 matching lines @@
 
 class InputApi(object):
   """An instance of this object is passed to presubmit scripts so they can
   know stuff about the change they're looking at.
   """
 
   # File extensions that are considered source files from a style guide
   # perspective. Don't modify this list from a presubmit script!
   DEFAULT_WHITE_LIST = (
       # C++ and friends
-      r".*\.c", r".*\.cc", r".*\.cpp", r".*\.h", r".*\.m", r".*\.mm",
-      r".*\.inl", r".*\.asm", r".*\.hxx", r".*\.hpp",
+      r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
+      r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$",
       # Scripts
-      r".*\.js", r".*\.py", r".*\.sh", r".*\.rb", r".*\.pl", r".*\.pm",
+      r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
       # No extension at all, note that ALL CAPS files are black listed in
       # DEFAULT_BLACK_LIST below.
-      r"(^|.*[\\\/])[^.]+$",
+      r"(^|.*?[\\\/])[^.]+$",

[Evan Martin, 2010/01/28 23:41:47]

Surprised this is needed, since .* matches the empty string anyway...

       # Other
-      r".*\.java", r".*\.mk", r".*\.am",
+      r".*\.java$", r".*\.mk$", r".*\.am$",
   )
 
   # Path regexp that should be excluded from being considered containing source
   # files. Don't modify this list from a presubmit script!
   DEFAULT_BLACK_LIST = (
       r".*\bexperimental[\\\/].*",
       r".*\bthird_party[\\\/].*",
       # Output directories (just in case)
       r".*\bDebug[\\\/].*",
       r".*\bRelease[\\\/].*",
@@ skipping 130 matching lines @@
     and InputApi.DEFAULT_BLACK_LIST is used respectively.
 
     The lists will be compiled as regular expression and
     AffectedFile.LocalPath() needs to pass both list.
 
     Note: Copy-paste this function to suit your needs or use a lambda function.
     """
     def Find(affected_file, list):
       for item in list:
         local_path = affected_file.LocalPath()
         if self.re.match(item, local_path):

[Evan Martin, 2010/01/28 23:41:47]

Could also just add a "$" here to make match() mean "match the whole string".

           logging.debug("%s matched %s" % (item, local_path))
           return True
       return False
     return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
             not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
 
   def AffectedSourceFiles(self, source_file):
     """Filter the list of AffectedTextFiles by the function source_file.
 
     If source_file is None, InputApi.FilterSourceFile() is used.
@@ skipping 726 matching lines @@
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                options.default_presubmit,
                                options.may_prompt)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))