Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558022: DevTools: fix console autocomplete against global object (while not on a brea... (Closed)

Created:
10 years, 11 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

DevTools: fix console autocomplete against global object (while not on a breakpoint). TBR=yurys BUG=33403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37506

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/glue/devtools/js/devtools.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
pfeldman
10 years, 11 months ago (2010-01-28 21:08:04 UTC) #1
yurys
http://codereview.chromium.org/558022/diff/1001/2001 File webkit/glue/devtools/js/devtools.js (right): http://codereview.chromium.org/558022/diff/1001/2001#newcode423 webkit/glue/devtools/js/devtools.js:423: if (typeof callFrameId === "number") { Could you explain ...
10 years, 11 months ago (2010-01-28 21:20:25 UTC) #2
pfeldman1
goog.isDef(null) === true. On Fri, Jan 29, 2010 at 12:20 AM, <yurys@chromium.org> wrote: > > ...
10 years, 10 months ago (2010-01-29 06:23:53 UTC) #3
yurys
10 years, 10 months ago (2010-01-29 10:27:07 UTC) #4 
On 2010/01/29 06:23:53, pfeldman_google.com wrote:
> goog.isDef(null) === true.
> 
> On Fri, Jan 29, 2010 at 12:20 AM, <mailto:yurys@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/558022/diff/1001/2001
> > File webkit/glue/devtools/js/devtools.js (right):
> >
> > http://codereview.chromium.org/558022/diff/1001/2001#newcode423
> > webkit/glue/devtools/js/devtools.js:423: if (typeof callFrameId ===
> > "number") {
> > Could you explain why the old code didn't work?
> >
> >
> > http://codereview.chromium.org/558022
> >
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698