webkit/glue/devtools/js/devtools.js - Issue 558022: DevTools: fix console autocomplete against global object (while not on a brea...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/devtools/js/devtools.js

Issue 558022: DevTools: fix console autocomplete against global object (while not on a brea... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/devtools/js/devtools.js

===================================================================

--- webkit/glue/devtools/js/devtools.js (revision 37405)

+++ webkit/glue/devtools/js/devtools.js (working copy)

@@ -420,7 +420,7 @@

var orig = InjectedScriptAccess.prototype.getCompletions;

InjectedScriptAccess.prototype.getCompletions = function(expressionString,

includeInspectorCommandLineAPI, callFrameId, reportCompletions) {

- if (goog.isDef(callFrameId)) {

+ if (typeof callFrameId === "number") {

yurys 2010/01/28 21:20:25 Could you explain why the old code didn't work?

devtools.tools.getDebuggerAgent().resolveCompletionsOnFrame(

expressionString, callFrameId, reportCompletions);

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »