Issue 5560007: Don't update icon of chrome app shortcuts from the favicon of the hosted URL.

Issue 5560007: Don't update icon of chrome app shortcuts from the favicon of the hosted URL. (Closed)

Created:
10 years ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Don't update icon of chrome app shortcuts from the favicon of the hosted URL. Panel apps should always launch in a panel. Get rid of the non-extension OpenApplicationWindow(). Add TODO to continue untangling. BUG=65632 TEST=Create a desktop shortcut for a hosted app. Quit chrome, open the shortcut. Icon should not change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68442

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rev commnets #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -24 lines)			Patch
M	chrome/browser/extensions/extension_prefs.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1	1 chunk	+14 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	4 chunks	+33 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

LGTM w/ nits. Don't forget to merge. http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser.h#newcode257 chrome/browser/ui/browser.h:257: // Open ...

10 years ago (2010-12-06 23:45:24 UTC) #2

Sam Kerner (Chrome)

10 years ago (2010-12-07 04:12:30 UTC) #3

http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser.h#new...
chrome/browser/ui/browser.h:257: // Open a window hosting a URL.  Used to
implement url app shortcuts.
On 2010/12/06 23:45:24, Aaron Boodman wrote:
> Don't all windows host URLs? Maybe "Open a URL in an app shortcut window".

Done.

http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser.h#new...
chrome/browser/ui/browser.h:260: static TabContents*
OpenUrlAppShortcutWindow(Profile* profile,
On 2010/12/06 23:45:24, Aaron Boodman wrote:
> Good terminology change 'app -> appshortcut', but whatabout
> OpenAppShortcutWindow instead?

Done.

http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/5560007/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:660: TabContents* app_window =
Browser::OpenUrlAppShortcutWindow(
On 2010/12/06 23:45:24, Aaron Boodman wrote:
> app_widow -> app_tab?

Done.

Expand Messages | Collapse Messages