Don't update icon of chrome app shortcuts from the favicon of the hosted URL.

chrome/browser/ui/browser.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 227 matching lines @@
       Profile* profile,
       const Extension* extension,
       extension_misc::LaunchContainer container,
       TabContents* existing_tab);
 
   // Opens a new application window for the specified url. If |as_panel|
   // is true, the application will be opened as a Browser::Type::APP_PANEL in
   // app panel window, otherwise it will be opened as as either
   // Browser::Type::APP a.k.a. "thin frame" (if |extension| is NULL) or
   // Browser::Type::EXTENSION_APP (if |extension| is non-NULL).
+  // If |app_browser| is not NULL, it is set to the browser that hosts the
+  // returned tab.
   static TabContents* OpenApplicationWindow(
       Profile* profile,
       const Extension* extension,
       extension_misc::LaunchContainer container,
-      const GURL& url);
+      const GURL& url,
+      Browser** app_browser);
 
-  // Open an application in a new application window.  Used to implement
-  // app shortcuts.
-  static TabContents* OpenApplicationWindow(Profile* profile, const GURL& url);
+  // Open a window hosting a URL.  Used to implement url app shortcuts.

[Aaron Boodman, 2010/12/06 23:45:24]

Don't all windows host URLs? Maybe "Open a URL in an app shortcut window".

[Sam Kerner (Chrome), 2010/12/07 04:12:30]

Done.

+  // If |update_shortcut| is true, update the name, description, and
+  // favicon of the shortcut.
+  static TabContents* OpenUrlAppShortcutWindow(Profile* profile,

[Aaron Boodman, 2010/12/06 23:45:24]

Good terminology change 'app -> appshortcut', but whatabout
OpenAppShortcutWindow instead?

[Sam Kerner (Chrome), 2010/12/07 04:12:30]

Done.

+                                               const GURL& url,
+                                               bool update_shortcut);
 
   // Open an application for |extension| in a new application tab, or
   // |existing_tab| if not NULL.  Returns NULL if there are no appropriate
   // existing browser windows for |profile|.
   static TabContents* OpenApplicationTab(Profile* profile,
                                          const Extension* extension,
                                          TabContents* existing_tab);
 
   // Opens a new window and opens the bookmark manager.
   static void OpenBookmarkManagerWindow(Profile* profile);
@@ skipping 841 matching lines @@
   // The profile's tab restore service. The service is owned by the profile,
   // and we install ourselves as an observer.
   TabRestoreService* tab_restore_service_;
 
   scoped_ptr<InstantController> instant_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_