Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8427)

Unified Diff: chrome/browser/ui/browser.h

Issue 5560007: Don't update icon of chrome app shortcuts from the favicon of the hosted URL. (Closed)
Patch Set: Rev commnets Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 77c21460cb644307709c20db35619d15d6a99a77..7eb50e54f80d0c06f7d71097d00e96e6174804ab 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -245,15 +245,24 @@ class Browser : public TabHandlerDelegate,
// app panel window, otherwise it will be opened as as either
// Browser::Type::APP a.k.a. "thin frame" (if |extension| is NULL) or
// Browser::Type::EXTENSION_APP (if |extension| is non-NULL).
+ // If |app_browser| is not NULL, it is set to the browser that hosts the
+ // returned tab.
static TabContents* OpenApplicationWindow(
Profile* profile,
const Extension* extension,
extension_misc::LaunchContainer container,
- const GURL& url);
-
- // Open an application in a new application window. Used to implement
- // app shortcuts.
- static TabContents* OpenApplicationWindow(Profile* profile, const GURL& url);
+ const GURL& url,
+ Browser** app_browser);
+
+ // Open |url| in an app shortcut window. If |update_shortcut| is true,
+ // update the name, description, and favicon of the shortcut.
+ // There are two kinds of app shortcuts: Shortcuts to a URL,
+ // and shortcuts that open an installed application. This function
+ // is used to open the former. To open the latter, use
+ // Browser::OpenApplicationWindow().
+ static TabContents* OpenAppShortcutWindow(Profile* profile,
+ const GURL& url,
+ bool update_shortcut);
// Open an application for |extension| in a new application tab, or
// |existing_tab| if not NULL. Returns NULL if there are no appropriate
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698