Issue 552157: Fixed race condition with AddressWatchTask and ServerConnectionManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552157: Fixed race condition with AddressWatchTask and ServerConnectionManager. (Closed)

Created:
10 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, pink (ping after 24hrs)

Visibility:
Public.

Description

Fixed race condition with AddressWatchTask and ServerConnectionManager. BUG=33162 TEST=manually with sleep() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37154

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -22 lines)			Patch
M	chrome/browser/sync/engine/net/syncapi_server_connection_manager.h	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc	View	1 chunk	+1 line, -10 lines	1 comment	Download
M	chrome/browser/sync/engine/syncapi.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM++ http://codereview.chromium.org/552157/diff/1/2 File chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc (right): http://codereview.chromium.org/552157/diff/1/2#newcode66 chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc:66: SyncAPIServerConnectionManager::~SyncAPIServerConnectionManager() {} may as well throw this in ...

10 years, 11 months ago (2010-01-26 20:08:45 UTC) #2

akalin

10 years, 11 months ago (2010-01-26 21:15:27 UTC) #3

On 2010/01/26 20:08:45, timsteele wrote:
> http://codereview.chromium.org/552157/diff/1/2#newcode66
> chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc:66:
> SyncAPIServerConnectionManager::~SyncAPIServerConnectionManager() {}
> may as well throw this in .h

I actually like having virtual methods in only a single compilation unit to
reduce work for the linker.

Submitting and merging soon.

Expand Messages | Collapse Messages