Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5338)

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 552157: Fixed race condition with AddressWatchTask and ServerConnectionManager. (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncapi.cc
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc
index ffedd850bb2f3d52d2f6be768a26433f60f4dfb6..3f0ad2dd59d2470092139b8e40116e3d055184e0 100755
--- a/chrome/browser/sync/engine/syncapi.cc
+++ b/chrome/browser/sync/engine/syncapi.cc
@@ -1086,7 +1086,8 @@ bool SyncManager::SyncInternal::Init(
string client_id = user_settings_->GetClientId();
connection_manager_.reset(new SyncAPIServerConnectionManager(
- sync_server_and_path, port, use_ssl, user_agent, client_id));
+ sync_server_and_path, port, use_ssl, user_agent, client_id,
+ post_factory));
// TODO(timsteele): This is temporary windows crap needed to listen for
// network status changes. We should either pump this up to the embedder to
@@ -1117,10 +1118,6 @@ bool SyncManager::SyncInternal::Init(
}
#endif
- // Hand over the bridged POST factory to be owned by the connection
- // dir_manager.
- connection_manager()->SetHttpPostProviderFactory(post_factory);
-
// Watch various objects for aggregated status.
allstatus()->WatchConnectionManager(connection_manager());

Powered by Google App Engine
This is Rietveld 408576698