Fixed race condition with AddressWatchTask and ServerConnectionManager.

chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/net/syncapi_server_connection_manager.h"
 
 #include "chrome/browser/sync/engine/net/http_return.h"
 #include "chrome/browser/sync/engine/syncapi.h"
 
 using browser_sync::HttpResponse;
@@ skipping 45 matching lines @@
     response->server_status = HttpResponse::SYNC_SERVER_ERROR;
 
   // Write the content into our buffer.
   buffer_.assign(http->GetResponseContent(), http->GetResponseContentLength());
 
   // We're done with the HttpPostProvider.
   factory_->Destroy(http);
   return true;
 }
 
-SyncAPIServerConnectionManager::~SyncAPIServerConnectionManager() {
-  delete post_provider_factory_;
-}
-
-void SyncAPIServerConnectionManager::SetHttpPostProviderFactory(
-    HttpPostProviderFactory* factory) {
-  if (post_provider_factory_)
-    delete post_provider_factory_;
-  post_provider_factory_ = factory;
-}
+SyncAPIServerConnectionManager::~SyncAPIServerConnectionManager() {}

[tim (not reviewing), 2010/01/26 20:08:45]

may as well throw this in .h

 
 }  // namespace sync_api