Issue 552144: Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552144: Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we ... (Closed)

Created:
10 years, 11 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
jam, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we had it before, except with an updated CC_LIST. BUG=none TEST=Using gcl from src/third_party/WebKit sends code reviews to codereview.chromium.org. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37069

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	gcl.py	View		1 chunk	+14 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

M-A Ruel

lgtm, thanks for the comment. We should add webkit codereview.settings but I guess they wouldn't ...

10 years, 11 months ago (2010-01-26 00:24:52 UTC) #2

lgtm