Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: gcl.py

Issue 552144: Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Wrapper script around Rietveld's upload.py that groups files into 6 """Wrapper script around Rietveld's upload.py that groups files into
7 changelists.""" 7 changelists."""
8 8
9 import getpass 9 import getpass
10 import os 10 import os
(...skipping 10 matching lines...) Expand all
21 import breakpad 21 import breakpad
22 22
23 # gcl now depends on gclient. 23 # gcl now depends on gclient.
24 from scm import SVN 24 from scm import SVN
25 import gclient_utils 25 import gclient_utils
26 26
27 __version__ = '1.1.3' 27 __version__ = '1.1.3'
28 28
29 29
30 CODEREVIEW_SETTINGS = { 30 CODEREVIEW_SETTINGS = {
31 # Ideally, we want to set |CODE_REVIEW_SERVER| to a generic server like
32 # codereview.appspot.com and remove |CC_LIST| and |VIEW_VC|. In practice, we
33 # need these settings so developers making changes in directories such as
34 # Chromium's src/third_party/WebKit will send change lists to the correct
35 # server.
36 #
37 # To make gcl send reviews to a different server, check in a file named
38 # "codereview.settings" (see |CODEREVIEW_SETTINGS_FILE| below) to your
39 # project's base directory and add the following line to codereview.settings:
40 # CODE_REVIEW_SERVER: codereview.yourserver.org
41 #
31 # Default values. 42 # Default values.
32 "CODE_REVIEW_SERVER": "codereview.appspot.com", 43 "CODE_REVIEW_SERVER": "codereview.chromium.org",
44 "CC_LIST": "chromium-reviews@chromium.org",
45 "VIEW_VC": "http://src.chromium.org/viewvc/chrome?view=rev&revision=",
33 } 46 }
34 47
35 # globals that store the root of the current repository and the directory where 48 # globals that store the root of the current repository and the directory where
36 # we store information about changelists. 49 # we store information about changelists.
37 REPOSITORY_ROOT = "" 50 REPOSITORY_ROOT = ""
38 51
39 # Filename where we store repository specific information for gcl. 52 # Filename where we store repository specific information for gcl.
40 CODEREVIEW_SETTINGS_FILE = "codereview.settings" 53 CODEREVIEW_SETTINGS_FILE = "codereview.settings"
41 54
42 # Warning message when the change appears to be missing tests. 55 # Warning message when the change appears to be missing tests.
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 return 0 1205 return 0
1193 args =["svn", command] 1206 args =["svn", command]
1194 root = GetRepositoryRoot() 1207 root = GetRepositoryRoot()
1195 args.extend([os.path.join(root, x) for x in change_info.GetFileNames()]) 1208 args.extend([os.path.join(root, x) for x in change_info.GetFileNames()])
1196 RunShell(args, True) 1209 RunShell(args, True)
1197 return 0 1210 return 0
1198 1211
1199 1212
1200 if __name__ == "__main__": 1213 if __name__ == "__main__":
1201 sys.exit(main()) 1214 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698