Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: gcl.py

Issue 552144: Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 37063)
+++ gcl.py (working copy)
@@ -28,8 +28,21 @@
CODEREVIEW_SETTINGS = {
+ # Ideally, we want to set |CODE_REVIEW_SERVER| to a generic server like
+ # codereview.appspot.com and remove |CC_LIST| and |VIEW_VC|. In practice, we
+ # need these settings so developers making changes in directories such as
+ # Chromium's src/third_party/WebKit will send change lists to the correct
+ # server.
+ #
+ # To make gcl send reviews to a different server, check in a file named
+ # "codereview.settings" (see |CODEREVIEW_SETTINGS_FILE| below) to your
+ # project's base directory and add the following line to codereview.settings:
+ # CODE_REVIEW_SERVER: codereview.yourserver.org
+ #
# Default values.
- "CODE_REVIEW_SERVER": "codereview.appspot.com",
+ "CODE_REVIEW_SERVER": "codereview.chromium.org",
+ "CC_LIST": "chromium-reviews@chromium.org",
+ "VIEW_VC": "http://src.chromium.org/viewvc/chrome?view=rev&revision=",
}
# globals that store the root of the current repository and the directory where
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698